<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [EFL] Jpeg image export implementation for Canvas."
href="https://bugs.webkit.org/show_bug.cgi?id=145457#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [EFL] Jpeg image export implementation for Canvas."
href="https://bugs.webkit.org/show_bug.cgi?id=145457">bug 145457</a>
from <span class="vcard"><a class="email" href="mailto:hyuki.kim@samsung.com" title="KwangHyuk <hyuki.kim@samsung.com>"> <span class="fn">KwangHyuk</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=145457#c7">comment #7</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=254579&action=diff" name="attach_254579" title="Patch">attachment 254579</a> <a href="attachment.cgi?id=254579&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=254579&action=review">https://bugs.webkit.org/attachment.cgi?id=254579&action=review</a>
>
> LGTM except for a trivial comment.
>
> > Source/WebCore/ChangeLog:10
> > + No new tests, LayoutTests/fast/canvas/toDataURL-supportedTypes.html can be reused.
>
> Unnecessary "LayoutTests/" in test path.
> </span >
Ok, thanks.
<span class="quote">> > Source/WebCore/platform/graphics/efl/ImageBufferEfl.cpp:75
> > + return "data:" + mimeType + ";base64," + base64Data;
>
> Isn't StringBuilder more efficient ?
>
> <a href="https://trac.webkit.org/wiki/EfficientStrings">https://trac.webkit.org/wiki/EfficientStrings</a></span >
But, this is the general implementation for every ports like ImageBufferGtk, ImageBufferCairo as well as ImageBufferCG.
Therefore, may be, keeping of this implementation looks fine.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>