[Webkit-unassigned] [Bug 145598] [GTK] Get rid of GetEditorCommandsForKeyEvent sync message

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145598

--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #6)
> Comment on attachment 254159 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254159&action=review
> 
> >>> Source/WebCore/dom/KeyboardEvent.cpp:233
> >>> +#endif
> >> 
> >> Why not use the m_handledByInputMethod boolean, like it's used for the Cocoa platform?
> > 
> > Because we don't need to duplicate that, this is just a convenient method, to avoid having to get the platform event, check if it's null, and then get the boolean.
> 
> I don't think using m_handledByInputMethod the same way it's used for
> PLATFORM(COCOA) && USE(APPKIT) is duplicating.

I didn't mean duplicating code, but duplicating the value in both objects.

> I do think adding a new
> GTK-specific method that queries some state that a KeyboardEvent constructor
> could already determine is duplicating.
> 
> But given that this is a Web-exposed class, any platform-specific code is
> regrettable.

I can avoid that entirely and use the platform keyboard event in the callers, as I said this was just a convenient method.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150610/69f91ccd/attachment.html>