<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Get rid of GetEditorCommandsForKeyEvent sync message"
href="https://bugs.webkit.org/show_bug.cgi?id=145598#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Get rid of GetEditorCommandsForKeyEvent sync message"
href="https://bugs.webkit.org/show_bug.cgi?id=145598">bug 145598</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=145598#c6">comment #6</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=254159&action=diff" name="attach_254159" title="Patch">attachment 254159</a> <a href="attachment.cgi?id=254159&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=254159&action=review">https://bugs.webkit.org/attachment.cgi?id=254159&action=review</a>
>
> >>> Source/WebCore/dom/KeyboardEvent.cpp:233
> >>> +#endif
> >>
> >> Why not use the m_handledByInputMethod boolean, like it's used for the Cocoa platform?
> >
> > Because we don't need to duplicate that, this is just a convenient method, to avoid having to get the platform event, check if it's null, and then get the boolean.
>
> I don't think using m_handledByInputMethod the same way it's used for
> PLATFORM(COCOA) && USE(APPKIT) is duplicating.</span >
I didn't mean duplicating code, but duplicating the value in both objects.
<span class="quote">> I do think adding a new
> GTK-specific method that queries some state that a KeyboardEvent constructor
> could already determine is duplicating.
>
> But given that this is a Web-exposed class, any platform-specific code is
> regrettable.</span >
I can avoid that entirely and use the platform keyboard event in the callers, as I said this was just a convenient method.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>