[Webkit-unassigned] [Bug 145457] [EFL] Jpeg image export implementation for Canvas.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145457

Gyuyoung Kim <gyuyoung.kim at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #254579|review?                     |review+
              Flags|                            |

--- Comment #7 from Gyuyoung Kim <gyuyoung.kim at webkit.org> ---
Comment on attachment 254579
  --> https://bugs.webkit.org/attachment.cgi?id=254579
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254579&action=review

LGTM except for a trivial comment.

> Source/WebCore/ChangeLog:10
> +        No new tests, LayoutTests/fast/canvas/toDataURL-supportedTypes.html can be reused.

Unnecessary "LayoutTests/" in test path.

> Source/WebCore/platform/graphics/efl/ImageBufferEfl.cpp:75
> +    return "data:" + mimeType + ";base64," + base64Data;

Isn't StringBuilder more efficient ?

https://trac.webkit.org/wiki/EfficientStrings

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150610/06074ca4/attachment.html>