<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:gyuyoung.kim@webkit.org" title="Gyuyoung Kim <gyuyoung.kim@webkit.org>"> <span class="fn">Gyuyoung Kim</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [EFL] Jpeg image export implementation for Canvas."
href="https://bugs.webkit.org/show_bug.cgi?id=145457">bug 145457</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #254579 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [EFL] Jpeg image export implementation for Canvas."
href="https://bugs.webkit.org/show_bug.cgi?id=145457#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [EFL] Jpeg image export implementation for Canvas."
href="https://bugs.webkit.org/show_bug.cgi?id=145457">bug 145457</a>
from <span class="vcard"><a class="email" href="mailto:gyuyoung.kim@webkit.org" title="Gyuyoung Kim <gyuyoung.kim@webkit.org>"> <span class="fn">Gyuyoung Kim</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=254579&action=diff" name="attach_254579" title="Patch">attachment 254579</a> <a href="attachment.cgi?id=254579&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=254579&action=review">https://bugs.webkit.org/attachment.cgi?id=254579&action=review</a>
LGTM except for a trivial comment.
<span class="quote">> Source/WebCore/ChangeLog:10
> + No new tests, LayoutTests/fast/canvas/toDataURL-supportedTypes.html can be reused.</span >
Unnecessary "LayoutTests/" in test path.
<span class="quote">> Source/WebCore/platform/graphics/efl/ImageBufferEfl.cpp:75
> + return "data:" + mimeType + ";base64," + base64Data;</span >
Isn't StringBuilder more efficient ?
<a href="https://trac.webkit.org/wiki/EfficientStrings">https://trac.webkit.org/wiki/EfficientStrings</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>