[Webkit-unassigned] [Bug 145806] Implement MediaSessionManager to keep track of all MediaSessions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145806

--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 254580
  --> https://bugs.webkit.org/attachment.cgi?id=254580
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254580&action=review

> Source/WebCore/Modules/mediasession/MediaSessionManager.cpp:49
> +    m_sessions.remove(m_sessions.find(&session));

Normally it’s not good to use remove/find. I’d suggest using a HashSet or ListHashSet for this collection instead of a vector.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150609/b5c6e80f/attachment.html>