<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement MediaSessionManager to keep track of all MediaSessions"
href="https://bugs.webkit.org/show_bug.cgi?id=145806#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement MediaSessionManager to keep track of all MediaSessions"
href="https://bugs.webkit.org/show_bug.cgi?id=145806">bug 145806</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=254580&action=diff" name="attach_254580" title="Patch">attachment 254580</a> <a href="attachment.cgi?id=254580&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=254580&action=review">https://bugs.webkit.org/attachment.cgi?id=254580&action=review</a>
<span class="quote">> Source/WebCore/Modules/mediasession/MediaSessionManager.cpp:49
> + m_sessions.remove(m_sessions.find(&session));</span >
Normally it’s not good to use remove/find. I’d suggest using a HashSet or ListHashSet for this collection instead of a vector.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>