[Webkit-unassigned] [Bug 145791] [SOUP] Network Cache: Give more priority to reads over writes in IO WorkQueue

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145791

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #5)
> Comment on attachment 254555 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254555&action=review
> 
> > Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:268
> >      runTaskInQueue([channel, offset, data, completionHandler] {
> >          channel->write(offset, data, completionHandler);
> > -    }, queue);
> > +    }, queue, G_PRIORITY_DEFAULT_IDLE);
> 
> This is never called with a non-null WorkQueue, meaning it's always
> scheduled on the main context. The point being, is the WorkQueue priority
> scheduling necessary?

It's rather the opposite, since it always receives a work queue, it's never scheduled in the main context, but in the work queue main context, and we still want IOChannel::read() to happen before IOChannel::write().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150609/94dc4432/attachment.html>