<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Network Cache: Give more priority to reads over writes in IO WorkQueue"
href="https://bugs.webkit.org/show_bug.cgi?id=145791#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Network Cache: Give more priority to reads over writes in IO WorkQueue"
href="https://bugs.webkit.org/show_bug.cgi?id=145791">bug 145791</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=145791#c5">comment #5</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=254555&action=diff" name="attach_254555" title="Patch">attachment 254555</a> <a href="attachment.cgi?id=254555&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=254555&action=review">https://bugs.webkit.org/attachment.cgi?id=254555&action=review</a>
>
> > Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:268
> > runTaskInQueue([channel, offset, data, completionHandler] {
> > channel->write(offset, data, completionHandler);
> > - }, queue);
> > + }, queue, G_PRIORITY_DEFAULT_IDLE);
>
> This is never called with a non-null WorkQueue, meaning it's always
> scheduled on the main context. The point being, is the WorkQueue priority
> scheduling necessary?</span >
It's rather the opposite, since it always receives a work queue, it's never scheduled in the main context, but in the work queue main context, and we still want IOChannel::read() to happen before IOChannel::write().</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>