[Webkit-unassigned] [Bug 145657] Web Inspector: Show warning icon for invalid CSS properties and/or values

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145657

Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #254385|review?                     |review-
              Flags|                            |

--- Comment #4 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 254385
  --> https://bugs.webkit.org/attachment.cgi?id=254385
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254385&action=review

> Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js:289
> +    getFirstMatchingProperty(name, clipFront)

Any way to make this faster? I worry it will be a performance bottleneck.

> Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js:296
> +        return this.getFirstMatchingProperty(clipFront ? name.substring(1): name.slice(0, -1), clipFront);

This is pretty heavy, and recursive.

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:548
> +                    title: "The value \"" + property.value + "\" is not valid.",

UIString here too.

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:556
> +                    title: "Did you mean " + closestPropertyName + "?",

This should be a format string with WebInspector.UIString.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150606/9907d1de/attachment.html>