<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:timothy@apple.com" title="Timothy Hatcher <timothy@apple.com>"> <span class="fn">Timothy Hatcher</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Show warning icon for invalid CSS properties and/or values"
href="https://bugs.webkit.org/show_bug.cgi?id=145657">bug 145657</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #254385 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Show warning icon for invalid CSS properties and/or values"
href="https://bugs.webkit.org/show_bug.cgi?id=145657#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Show warning icon for invalid CSS properties and/or values"
href="https://bugs.webkit.org/show_bug.cgi?id=145657">bug 145657</a>
from <span class="vcard"><a class="email" href="mailto:timothy@apple.com" title="Timothy Hatcher <timothy@apple.com>"> <span class="fn">Timothy Hatcher</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=254385&action=diff" name="attach_254385" title="Patch">attachment 254385</a> <a href="attachment.cgi?id=254385&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=254385&action=review">https://bugs.webkit.org/attachment.cgi?id=254385&action=review</a>
<span class="quote">> Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js:289
> + getFirstMatchingProperty(name, clipFront)</span >
Any way to make this faster? I worry it will be a performance bottleneck.
<span class="quote">> Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js:296
> + return this.getFirstMatchingProperty(clipFront ? name.substring(1): name.slice(0, -1), clipFront);</span >
This is pretty heavy, and recursive.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:548
> + title: "The value \"" + property.value + "\" is not valid.",</span >
UIString here too.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:556
> + title: "Did you mean " + closestPropertyName + "?",</span >
This should be a format string with WebInspector.UIString.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>