[Webkit-unassigned] [Bug 145399] Web Inspector: Highlighting a CSS section does not deselect previously highlighted CSS sections

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145399

Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #254102|review?                     |review-
              Flags|                            |

--- Comment #3 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 254102
  --> https://bugs.webkit.org/attachment.cgi?id=254102
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254102&action=review

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js:287
> +        this._delegate.editorFocused(this);

This should check for existence of the auction before calling it. This would also be "cssStyleDeclarationSectionEditorFocused".

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:73
> +        if (typeof this._delegate.editorFocused === "function")

Delegate methods should be prefixed with the class name, so they can't conflict with others or built-in methods. So this should be "cssStyleDeclarationTextEditorFocused" to match the other delegate methods on this class.

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:330
> +        if (typeof this._delegate.editorFocused === "function")
> +            this._delegate.editorFocused();

Ditto.

> Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js:260
> +    editorFocused(ignoredSection)

This would be cssStyleDeclarationSectionEditorFocused.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150605/9d2da298/attachment.html>