<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:timothy@apple.com" title="Timothy Hatcher <timothy@apple.com>"> <span class="fn">Timothy Hatcher</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Highlighting a CSS section does not deselect previously highlighted CSS sections"
href="https://bugs.webkit.org/show_bug.cgi?id=145399">bug 145399</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #254102 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Highlighting a CSS section does not deselect previously highlighted CSS sections"
href="https://bugs.webkit.org/show_bug.cgi?id=145399#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Highlighting a CSS section does not deselect previously highlighted CSS sections"
href="https://bugs.webkit.org/show_bug.cgi?id=145399">bug 145399</a>
from <span class="vcard"><a class="email" href="mailto:timothy@apple.com" title="Timothy Hatcher <timothy@apple.com>"> <span class="fn">Timothy Hatcher</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=254102&action=diff" name="attach_254102" title="Patch">attachment 254102</a> <a href="attachment.cgi?id=254102&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=254102&action=review">https://bugs.webkit.org/attachment.cgi?id=254102&action=review</a>
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js:287
> + this._delegate.editorFocused(this);</span >
This should check for existence of the auction before calling it. This would also be "cssStyleDeclarationSectionEditorFocused".
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:73
> + if (typeof this._delegate.editorFocused === "function")</span >
Delegate methods should be prefixed with the class name, so they can't conflict with others or built-in methods. So this should be "cssStyleDeclarationTextEditorFocused" to match the other delegate methods on this class.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:330
> + if (typeof this._delegate.editorFocused === "function")
> + this._delegate.editorFocused();</span >
Ditto.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js:260
> + editorFocused(ignoredSection)</span >
This would be cssStyleDeclarationSectionEditorFocused.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>