[Webkit-unassigned] [Bug 141262] Web Inspector: if a known CSS property has an unsupported value, only strikethrough the value

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=141262

--- Comment #9 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 254219
  --> https://bugs.webkit.org/attachment.cgi?id=254219
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254219&action=review

>>> Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js:279
>>> +    nameMatchesValidPropertyExactly(name)
>> 
>> Do we need to do anything special for properties that can have a "-webkit-" prefix or not? Like transform can, and some others.
> 
> I tested this with a few different "-webkit-" prefixed properties and it worked correctly without any issues, so no.  As far as I understand, the property name includes "-webkit-" so it will match with that in mind.  If I had used canonicalName, then this would be a problem as it strips prefixes.

This name reads weird to me. How about isValidPropertyName or isSupportedPropertyName?

>> Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js:281
>> +        for (var property of this._values) {
> 
> Array.prototype.includes?

Yes!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150604/30a3acbb/attachment.html>