<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Web Inspector: if a known CSS property has an unsupported value, only strikethrough the value"
href="https://bugs.webkit.org/show_bug.cgi?id=141262#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Web Inspector: if a known CSS property has an unsupported value, only strikethrough the value"
href="https://bugs.webkit.org/show_bug.cgi?id=141262">bug 141262</a>
from <span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=254219&action=diff" name="attach_254219" title="Patch">attachment 254219</a> <a href="attachment.cgi?id=254219&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=254219&action=review">https://bugs.webkit.org/attachment.cgi?id=254219&action=review</a>
<span class="quote">>>> Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js:279
>>> + nameMatchesValidPropertyExactly(name)
>>
>> Do we need to do anything special for properties that can have a "-webkit-" prefix or not? Like transform can, and some others.
>
> I tested this with a few different "-webkit-" prefixed properties and it worked correctly without any issues, so no. As far as I understand, the property name includes "-webkit-" so it will match with that in mind. If I had used canonicalName, then this would be a problem as it strips prefixes.</span >
This name reads weird to me. How about isValidPropertyName or isSupportedPropertyName?
<span class="quote">>> Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js:281
>> + for (var property of this._values) {
>
> Array.prototype.includes?</span >
Yes!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>