[Webkit-unassigned] [Bug 145581] Add basic Media Session support to HTMLMediaElement

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 3 15:10:37 PDT 2015


--- Comment #16 from Matt Rajca <mrajca at apple.com> ---
(In reply to comment #15)
> Comment on attachment 254206 [details]
> Patch (speculative Windows build fix)
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254206&action=review
> >>> Source/WebCore/Modules/mediasession/HTMLMediaElementMediaSession.h:42
> >>> +    static void setSession(HTMLMediaElement* element, MediaSession* session) { element->setSession(session); }
> >> 
> >> These should all take HTMLMediaElement&, not HTMLMediaElement*.
> > 
> > Per the Media Session spec, we should be able to set the session to null, which we won't be able to do with references.
> Then all the function bodies in this class, all of which unconditionally
> dereference the element pointer, are incorrect.
> Setting a session to null would depend on the type MediaSession*, not
> HTMLMediaElement*.

I misread the original feedback. MediaSessions might be null, but HTMLMediaElements will never be null (when jsHTMLMediaElementSession calls these functions it will always pass in a HTMLMediaElement). We could use references, but those aren't compatible with the bindings generated. So I will leave pointers to HTMLMediaElements but add assertions (which is what we do in HTMLMediaElementMediaSource).

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150603/8a0db497/attachment-0001.html>

More information about the webkit-unassigned mailing list