[Webkit-unassigned] [Bug 145581] Add basic Media Session support to HTMLMediaElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145581

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #254206|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #15 from Darin Adler <darin at apple.com> ---
Comment on attachment 254206
  --> https://bugs.webkit.org/attachment.cgi?id=254206
Patch (speculative Windows build fix)

View in context: https://bugs.webkit.org/attachment.cgi?id=254206&action=review

>>> Source/WebCore/Modules/mediasession/HTMLMediaElementMediaSession.h:42
>>> +    static void setSession(HTMLMediaElement* element, MediaSession* session) { element->setSession(session); }
>> 
>> These should all take HTMLMediaElement&, not HTMLMediaElement*.
> 
> Per the Media Session spec, we should be able to set the session to null, which we won't be able to do with references.

Then all the function bodies in this class, all of which unconditionally dereference the element pointer, are incorrect.

Setting a session to null would depend on the type MediaSession*, not HTMLMediaElement*.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150603/7f35d24c/attachment-0001.html>