[Webkit-unassigned] [Bug 145581] Add basic Media Session support to HTMLMediaElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145581

--- Comment #13 from Matt Rajca <mrajca at apple.com> ---
Comment on attachment 254206
  --> https://bugs.webkit.org/attachment.cgi?id=254206
Patch (speculative Windows build fix)

View in context: https://bugs.webkit.org/attachment.cgi?id=254206&action=review

>> Source/WebCore/Modules/mediasession/HTMLMediaElementMediaSession.h:32
>> +#include <wtf/text/WTFString.h>
> 
> Don’t need this.

Removed.

>> Source/WebCore/Modules/mediasession/HTMLMediaElementMediaSession.h:36
>> +class HTMLMediaElementMediaSession {
> 
> What determines the interface and name of this class? It seems quite strange and I am not sure exactly what it’s for.
> 
> I might omit the second occurrence of the word “Media” but I’m not sure enough of context to know if that suggestion is OK.

I see it as MediaSession "extensions" on HTMLMediaElement. We do something similar for MediaStream in HTMLMediaElementMediaStream.

I want to keep the second occurrence of the word "Media" in there so it's clear this is referring to the Media Session API rather than a different session.

>> Source/WebCore/Modules/mediasession/HTMLMediaElementMediaSession.h:42
>> +    static void setSession(HTMLMediaElement* element, MediaSession* session) { element->setSession(session); }
> 
> These should all take HTMLMediaElement&, not HTMLMediaElement*.

Per the Media Session spec, we should be able to set the session to null, which we won't be able to do with references.

>> Source/WebCore/html/HTMLMediaElement.h:422
>> +    void setSession(MediaSession*);
> 
> Might want this to take RefPtr<MediaSession>&& instead, if callers are handing over ownership. If ownership is usually shared, then raw pointer is OK/better.

A session can (and often will) be shared between multiple media elements. I'll keep this as is.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150603/57a8d43c/attachment.html>