[Webkit-unassigned] [Bug 145523] Media Session API: Implement methods required by the EventTarget interface in MediaRemoteControls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145523

Matt Rajca <mrajca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #254012|                            |review?, commit-queue?
              Flags|                            |

--- Comment #6 from Matt Rajca <mrajca at apple.com> ---
Comment on attachment 254012
  --> https://bugs.webkit.org/attachment.cgi?id=254012
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254012&action=review

>> Source/WebCore/ChangeLog:10
>> +        * Modules/mediasession/MediaRemoteControls.h: MediaRemoteControl's constructor now takes a script execution context, which we provide to EventTarget. The required eventTargetInterface method has also been implemented.
> 
> Please wrap these very long lines to a reasonable window width

Done.

>> Source/WebCore/Modules/mediasession/MediaRemoteControls.cpp:38
>> +    , m_seekBackwardEnabled(false)
> 
> These should be initialized in the header with class member initializers, eg:
> 
> bool m_previousTrackEnabled { false };
> 
> etc

Done.

>>> Source/WebCore/Modules/mediasession/MediaRemoteControls.idl:40
>>> +    //attribute EventHandler onseekbackward;
>> 
>> I think we usually avoid checking in commented-out code. Could this just temporarily be deleted? (If we do commit commented-out code, a comment to make it clear this wasn't an accidental check-in might be warranted.)
> 
> Agreed, we generally don't check in commented-out code.

Removed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150601/18c31095/attachment.html>