<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mrajca@apple.com" title="Matt Rajca <mrajca@apple.com>"> <span class="fn">Matt Rajca</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session API: Implement methods required by the EventTarget interface in MediaRemoteControls"
href="https://bugs.webkit.org/show_bug.cgi?id=145523">bug 145523</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #254012 Flags</td>
<td>
</td>
<td>review?, commit-queue?
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session API: Implement methods required by the EventTarget interface in MediaRemoteControls"
href="https://bugs.webkit.org/show_bug.cgi?id=145523#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session API: Implement methods required by the EventTarget interface in MediaRemoteControls"
href="https://bugs.webkit.org/show_bug.cgi?id=145523">bug 145523</a>
from <span class="vcard"><a class="email" href="mailto:mrajca@apple.com" title="Matt Rajca <mrajca@apple.com>"> <span class="fn">Matt Rajca</span></a>
</span></b>
<pre>Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=254012&action=diff" name="attach_254012" title="Patch">attachment 254012</a> <a href="attachment.cgi?id=254012&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=254012&action=review">https://bugs.webkit.org/attachment.cgi?id=254012&action=review</a>
<span class="quote">>> Source/WebCore/ChangeLog:10
>> + * Modules/mediasession/MediaRemoteControls.h: MediaRemoteControl's constructor now takes a script execution context, which we provide to EventTarget. The required eventTargetInterface method has also been implemented.
>
> Please wrap these very long lines to a reasonable window width</span >
Done.
<span class="quote">>> Source/WebCore/Modules/mediasession/MediaRemoteControls.cpp:38
>> + , m_seekBackwardEnabled(false)
>
> These should be initialized in the header with class member initializers, eg:
>
> bool m_previousTrackEnabled { false };
>
> etc</span >
Done.
<span class="quote">>>> Source/WebCore/Modules/mediasession/MediaRemoteControls.idl:40
>>> + //attribute EventHandler onseekbackward;
>>
>> I think we usually avoid checking in commented-out code. Could this just temporarily be deleted? (If we do commit commented-out code, a comment to make it clear this wasn't an accidental check-in might be warranted.)
>
> Agreed, we generally don't check in commented-out code.</span >
Removed.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>