[Webkit-unassigned] [Bug 145523] Media Session API: Implement methods required by the EventTarget interface in MediaRemoteControls

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 1 14:07:04 PDT 2015


--- Comment #3 from Conrad Shultz <conrad_shultz at apple.com> ---
Comment on attachment 254012
  --> https://bugs.webkit.org/attachment.cgi?id=254012

View in context: https://bugs.webkit.org/attachment.cgi?id=254012&action=review

> Source/WebCore/ChangeLog:12
> +        * Modules/mediasession/MediaRemoteControls.idl: Indicate MediaRemoteControls now takes a constructor that is passed in a script execution context. Event handlers have been uncommented until they are implemented to prevent build errors.

I think you meant commented?

> Source/WebCore/Modules/mediasession/MediaRemoteControls.idl:40
> +    //attribute EventHandler onseekbackward;

I think we usually avoid checking in commented-out code. Could this just temporarily be deleted? (If we do commit commented-out code, a comment to make it clear this wasn't an accidental check-in might be warranted.)

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150601/e0dcd516/attachment.html>

More information about the webkit-unassigned mailing list