<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session API: Implement methods required by the EventTarget interface in MediaRemoteControls"
href="https://bugs.webkit.org/show_bug.cgi?id=145523#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session API: Implement methods required by the EventTarget interface in MediaRemoteControls"
href="https://bugs.webkit.org/show_bug.cgi?id=145523">bug 145523</a>
from <span class="vcard"><a class="email" href="mailto:conrad_shultz@apple.com" title="Conrad Shultz <conrad_shultz@apple.com>"> <span class="fn">Conrad Shultz</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=254012&action=diff" name="attach_254012" title="Patch">attachment 254012</a> <a href="attachment.cgi?id=254012&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=254012&action=review">https://bugs.webkit.org/attachment.cgi?id=254012&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:12
> + * Modules/mediasession/MediaRemoteControls.idl: Indicate MediaRemoteControls now takes a constructor that is passed in a script execution context. Event handlers have been uncommented until they are implemented to prevent build errors.</span >
I think you meant commented?
<span class="quote">> Source/WebCore/Modules/mediasession/MediaRemoteControls.idl:40
> + //attribute EventHandler onseekbackward;</span >
I think we usually avoid checking in commented-out code. Could this just temporarily be deleted? (If we do commit commented-out code, a comment to make it clear this wasn't an accidental check-in might be warranted.)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>