[Webkit-unassigned] [Bug 145462] Add stub implementation of MediaRemoteControls, part of Media Session spec

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145462

Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #253923|review?                     |review+
              Flags|                            |

--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 253923
  --> https://bugs.webkit.org/attachment.cgi?id=253923
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253923&action=review

>> Source/WebCore/Modules/mediasession/MediaRemoteControls.cpp:29
>> +#if ENABLE(MEDIA_SESSION)
> 
> Would it make sense for this to be above the includes?

This is the pattern typically used throughout WebKit.

> Source/WebCore/Modules/mediasession/MediaRemoteControls.h:53
> +    virtual ~MediaRemoteControls();

Does the destructor need to be public?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150601/ed7e1d5b/attachment.html>