<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add stub implementation of MediaRemoteControls, part of Media Session spec"
href="https://bugs.webkit.org/show_bug.cgi?id=145462">bug 145462</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #253923 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add stub implementation of MediaRemoteControls, part of Media Session spec"
href="https://bugs.webkit.org/show_bug.cgi?id=145462#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add stub implementation of MediaRemoteControls, part of Media Session spec"
href="https://bugs.webkit.org/show_bug.cgi?id=145462">bug 145462</a>
from <span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=253923&action=diff" name="attach_253923" title="Patch">attachment 253923</a> <a href="attachment.cgi?id=253923&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=253923&action=review">https://bugs.webkit.org/attachment.cgi?id=253923&action=review</a>
<span class="quote">>> Source/WebCore/Modules/mediasession/MediaRemoteControls.cpp:29
>> +#if ENABLE(MEDIA_SESSION)
>
> Would it make sense for this to be above the includes?</span >
This is the pattern typically used throughout WebKit.
<span class="quote">> Source/WebCore/Modules/mediasession/MediaRemoteControls.h:53
> + virtual ~MediaRemoteControls();</span >
Does the destructor need to be public?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>