[Webkit-unassigned] [Bug 147393] Parse the entire WebAssembly modules

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147393

--- Comment #8 from Saam Barati <saambarati1 at gmail.com> ---
Comment on attachment 257910
  --> https://bugs.webkit.org/attachment.cgi?id=257910
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257910&action=review

> Source/JavaScriptCore/wasm/WASMReader.cpp:83
> +    CHECK_READ(1);

Why not do everything in the loop?

> Source/JavaScriptCore/wasm/WASMReader.cpp:89
> +    while (true) {

What's stopping this from reading more than 4 bytes?

> Source/JavaScriptCore/wasm/WASMReader.cpp:96
> +        result |= (byte & 0x7f) << shift;

Or maybe the limit is we can read at most 5 bytes?
Can compact int values be larger than 2^28?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150731/f3773e7e/attachment.html>