<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Parse the entire WebAssembly modules"
href="https://bugs.webkit.org/show_bug.cgi?id=147393#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Parse the entire WebAssembly modules"
href="https://bugs.webkit.org/show_bug.cgi?id=147393">bug 147393</a>
from <span class="vcard"><a class="email" href="mailto:saambarati1@gmail.com" title="Saam Barati <saambarati1@gmail.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=257910&action=diff" name="attach_257910" title="Patch">attachment 257910</a> <a href="attachment.cgi?id=257910&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=257910&action=review">https://bugs.webkit.org/attachment.cgi?id=257910&action=review</a>
<span class="quote">> Source/JavaScriptCore/wasm/WASMReader.cpp:83
> + CHECK_READ(1);</span >
Why not do everything in the loop?
<span class="quote">> Source/JavaScriptCore/wasm/WASMReader.cpp:89
> + while (true) {</span >
What's stopping this from reading more than 4 bytes?
<span class="quote">> Source/JavaScriptCore/wasm/WASMReader.cpp:96
> + result |= (byte & 0x7f) << shift;</span >
Or maybe the limit is we can read at most 5 bytes?
Can compact int values be larger than 2^28?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>