[Webkit-unassigned] [Bug 147280] Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147280

Jason Marcell <jmarcell at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #257853|                            |review?
              Flags|                            |

--- Comment #3 from Jason Marcell <jmarcell at apple.com> ---
Created attachment 257853
  --> https://bugs.webkit.org/attachment.cgi?id=257853&action=review
Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.

1. I fixed up the change log to use "Ditto."
2. I created a set of constants for repository names so that we're no longer using magic strings. I also have a plan in place for using these constants in a subsequent patch.
3. I moved the comment about "got_revision" formats to a more relevant section of the codebase.
4. I made the fallbackKey null by default.
5. I declared key and fallbackKey at the top of this if statement and created a new "else" clause:

var key;
var fallbackKey;
if (repository === "openSource") {
    ...
} else if (repository === "internal") {
    ...
} else {
    key = repository;
    fallbackKey = null;
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150730/5d28c9e6/attachment.html>