<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:jmarcell@apple.com" title="Jason Marcell <jmarcell@apple.com>"> <span class="fn">Jason Marcell</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions"
href="https://bugs.webkit.org/show_bug.cgi?id=147280">bug 147280</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #257853 Flags</td>
<td>
</td>
<td>review?
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions"
href="https://bugs.webkit.org/show_bug.cgi?id=147280#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions"
href="https://bugs.webkit.org/show_bug.cgi?id=147280">bug 147280</a>
from <span class="vcard"><a class="email" href="mailto:jmarcell@apple.com" title="Jason Marcell <jmarcell@apple.com>"> <span class="fn">Jason Marcell</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=257853&action=diff" name="attach_257853" title="Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.">attachment 257853</a> <a href="attachment.cgi?id=257853&action=edit" title="Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.">[details]</a></span>
Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.
1. I fixed up the change log to use "Ditto."
2. I created a set of constants for repository names so that we're no longer using magic strings. I also have a plan in place for using these constants in a subsequent patch.
3. I moved the comment about "got_revision" formats to a more relevant section of the codebase.
4. I made the fallbackKey null by default.
5. I declared key and fallbackKey at the top of this if statement and created a new "else" clause:
var key;
var fallbackKey;
if (repository === "openSource") {
...
} else if (repository === "internal") {
...
} else {
key = repository;
fallbackKey = null;
}</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>