[Webkit-unassigned] [Bug 147107] Adding default implementation for JavaScript watchdog.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147107

--- Comment #17 from Mark Lam <mark.lam at apple.com> ---
(In reply to comment #16)
> Comment on attachment 257832 [details]
> Patch
> 
> Not asking for review, just saving the work in progress...
> 
> Thanks Mark for you comment on Bug 131082, it seems I missed the obvious...
> Calling JSContextGroupSetExecutionTimeLimit() from a WebExtension / injected
> bundle is working fine... while using the appropriate callback.
> 
> In this concern "load_started" is fine because it is calling
> JSContextGroupSetExecutionTimeLimit() for each page load hence reseting
> m_didFire state
> 
> I can try to use WTF::WorkQueue, it sounds great!
> Actually it seems we could apply the same treatment to remove / refactor
> heap/HeapTimer.cpp/.h

FYI, since I didn’t hear back from you for a bit, I’ve actually implemented the changes to use WorkQueue (I think).  I’m currently testing it for some edge cases.  I plan upload a patch soon.  Thought I’d let you know so that we don’t do redundant work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150730/3efa0977/attachment.html>