<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Adding default implementation for JavaScript watchdog."
href="https://bugs.webkit.org/show_bug.cgi?id=147107#c17">Comment # 17</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Adding default implementation for JavaScript watchdog."
href="https://bugs.webkit.org/show_bug.cgi?id=147107">bug 147107</a>
from <span class="vcard"><a class="email" href="mailto:mark.lam@apple.com" title="Mark Lam <mark.lam@apple.com>"> <span class="fn">Mark Lam</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=147107#c16">comment #16</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=257832&action=diff" name="attach_257832" title="Patch">attachment 257832</a> <a href="attachment.cgi?id=257832&action=edit" title="Patch">[details]</a></span>
> Patch
>
> Not asking for review, just saving the work in progress...
>
> Thanks Mark for you comment on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - watchdog m_didFire state erroneously retained"
href="show_bug.cgi?id=131082">Bug 131082</a>, it seems I missed the obvious...
> Calling JSContextGroupSetExecutionTimeLimit() from a WebExtension / injected
> bundle is working fine... while using the appropriate callback.
>
> In this concern "load_started" is fine because it is calling
> JSContextGroupSetExecutionTimeLimit() for each page load hence reseting
> m_didFire state
>
> I can try to use WTF::WorkQueue, it sounds great!
> Actually it seems we could apply the same treatment to remove / refactor
> heap/HeapTimer.cpp/.h</span >
FYI, since I didn’t hear back from you for a bit, I’ve actually implemented the changes to use WorkQueue (I think). I’m currently testing it for some edge cases. I plan upload a patch soon. Thought I’d let you know so that we don’t do redundant work.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>