[Webkit-unassigned] [Bug 147178] Replace Google App Engine with AppScale

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147178

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #257590|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 257590
  --> https://bugs.webkit.org/attachment.cgi?id=257590
Patch for migrating from google appengine to appscale

View in context: https://bugs.webkit.org/attachment.cgi?id=257590&action=review

> LayoutTests/fast/harness/results.html:636
> +    return 'http://webkit-test-results.webkit.org:8081/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=' + encodeURIComponent(testList);

This is OK for now. Once we transition from appspot.com we should look to remove the need to explicitly specify a port number when accessing webkit-test-results.webkit.org. We will need to apply this change throughout this patch.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:41
> +    this.baseURL = "http://webkit-queues.webkit.org:8080/";

Notice the queues.webkit.org currently HTTP redirects to <http://webkit-queues.appspot.com>. Can we make use of this existing CNAME instead of defining a new CNAME, webkit-queues?

This is OK for now. Once we transition from appspot.com we should look to remove the need to explicitly specify a port number when accessing webkit-queues.webkit.org. We will need to apply this change throughout this patch.

> Tools/QueueStatusServer/app.yaml:4
> +threadsafe: false

I'm assuming you verified that this setting is acceptable.

> Tools/TestResultServer/app.yaml:4
> +threadsafe: false

Ditto.

> Tools/TestResultServer/static-dashboards/loader.js:34
> -var TEST_RESULTS_SERVER = 'https://webkit-test-results.appspot.com/';
> +var TEST_RESULTS_SERVER = 'http://webkit-test-results.webkit.org:8081/';

Could this cause mixed content warnings?

> Websites/bugs.webkit.org/code-review.js:583
> -      statusBubble.src  = 'https://webkit-queues.appspot.com/status-bubble/' + attachment_id;
> +      statusBubble.src  = 'http://webkit-queues.webkit.org:8080/status-bubble/' + attachment_id;

r-; This will lead to a mixed content warning for each status bubble (*) because we are fetching content from a HTTP URL instead of an HTTPS URL.

(*) We redirect all HTTP traffic on bugs.webkit.org to use HTTPS.

> Websites/bugs.webkit.org/template/en/default/attachment/edit.html.tmpl:267
> -          <iframe src="https://webkit-queues.appspot.com/status-bubble/[% attachment.id %]"
> +          <iframe src="http://webkit-queues.webkit.org:8080/status-bubble/[% attachment.id %]"

This will cause a mixed content warning by a similar argument as for the status bubbles (above).

> Websites/bugs.webkit.org/template/en/default/attachment/list.html.tmpl:160
> -            <iframe src="https://webkit-queues.appspot.com/status-bubble/[% attachment.id %]"
> +            <iframe src="http://webkit-queues.webkit.org:8080/status-bubble/[% attachment.id %]"

Ditto.

> Websites/bugs.webkit.org/template/en/default/attachment/reviewform.html.tmpl:97
> -        <iframe src="https://webkit-queues.appspot.com/status-bubble/[% attachment.id %]"
> +        <iframe src="http://webkit-queues.webkit.org:8080/status-bubble/[% attachment.id %]"

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150728/afdcfc31/attachment.html>