<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Replace Google App Engine with AppScale"
href="https://bugs.webkit.org/show_bug.cgi?id=147178">bug 147178</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #257590 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Replace Google App Engine with AppScale"
href="https://bugs.webkit.org/show_bug.cgi?id=147178#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Replace Google App Engine with AppScale"
href="https://bugs.webkit.org/show_bug.cgi?id=147178">bug 147178</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=257590&action=diff" name="attach_257590" title="Patch for migrating from google appengine to appscale">attachment 257590</a> <a href="attachment.cgi?id=257590&action=edit" title="Patch for migrating from google appengine to appscale">[details]</a></span>
Patch for migrating from google appengine to appscale
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=257590&action=review">https://bugs.webkit.org/attachment.cgi?id=257590&action=review</a>
<span class="quote">> LayoutTests/fast/harness/results.html:636
> + return '<a href="http://webkit-test-results.webkit.org:8081/dashboards/flakiness_dashboard.html#showAllRuns=true&tests">http://webkit-test-results.webkit.org:8081/dashboards/flakiness_dashboard.html#showAllRuns=true&tests</a>=' + encodeURIComponent(testList);</span >
This is OK for now. Once we transition from appspot.com we should look to remove the need to explicitly specify a port number when accessing webkit-test-results.webkit.org. We will need to apply this change throughout this patch.
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:41
> + this.baseURL = "<a href="http://webkit-queues.webkit.org:8080/">http://webkit-queues.webkit.org:8080/</a>";</span >
Notice the queues.webkit.org currently HTTP redirects to <<a href="http://webkit-queues.appspot.com">http://webkit-queues.appspot.com</a>>. Can we make use of this existing CNAME instead of defining a new CNAME, webkit-queues?
This is OK for now. Once we transition from appspot.com we should look to remove the need to explicitly specify a port number when accessing webkit-queues.webkit.org. We will need to apply this change throughout this patch.
<span class="quote">> Tools/QueueStatusServer/app.yaml:4
> +threadsafe: false</span >
I'm assuming you verified that this setting is acceptable.
<span class="quote">> Tools/TestResultServer/app.yaml:4
> +threadsafe: false</span >
Ditto.
<span class="quote">> Tools/TestResultServer/static-dashboards/loader.js:34
> -var TEST_RESULTS_SERVER = '<a href="https://webkit-test-results.appspot.com/">https://webkit-test-results.appspot.com/</a>';
> +var TEST_RESULTS_SERVER = '<a href="http://webkit-test-results.webkit.org:8081/">http://webkit-test-results.webkit.org:8081/</a>';</span >
Could this cause mixed content warnings?
<span class="quote">> Websites/bugs.webkit.org/code-review.js:583
> - statusBubble.src = '<a href="https://webkit-queues.appspot.com/status-bubble/">https://webkit-queues.appspot.com/status-bubble/</a>' + attachment_id;
> + statusBubble.src = '<a href="http://webkit-queues.webkit.org:8080/status-bubble/">http://webkit-queues.webkit.org:8080/status-bubble/</a>' + attachment_id;</span >
r-; This will lead to a mixed content warning for each status bubble (*) because we are fetching content from a HTTP URL instead of an HTTPS URL.
(*) We redirect all HTTP traffic on bugs.webkit.org to use HTTPS.
<span class="quote">> Websites/bugs.webkit.org/template/en/default/attachment/edit.html.tmpl:267
> - <iframe src="<a href="https://webkit-queues.appspot.com/status-bubble/">https://webkit-queues.appspot.com/status-bubble/</a>[% attachment.id %]"
> + <iframe src="<a href="http://webkit-queues.webkit.org:8080/status-bubble/">http://webkit-queues.webkit.org:8080/status-bubble/</a>[% attachment.id %]"</span >
This will cause a mixed content warning by a similar argument as for the status bubbles (above).
<span class="quote">> Websites/bugs.webkit.org/template/en/default/attachment/list.html.tmpl:160
> - <iframe src="<a href="https://webkit-queues.appspot.com/status-bubble/">https://webkit-queues.appspot.com/status-bubble/</a>[% attachment.id %]"
> + <iframe src="<a href="http://webkit-queues.webkit.org:8080/status-bubble/">http://webkit-queues.webkit.org:8080/status-bubble/</a>[% attachment.id %]"</span >
Ditto.
<span class="quote">> Websites/bugs.webkit.org/template/en/default/attachment/reviewform.html.tmpl:97
> - <iframe src="<a href="https://webkit-queues.appspot.com/status-bubble/">https://webkit-queues.appspot.com/status-bubble/</a>[% attachment.id %]"
> + <iframe src="<a href="http://webkit-queues.webkit.org:8080/status-bubble/">http://webkit-queues.webkit.org:8080/status-bubble/</a>[% attachment.id %]"</span >
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>