[Webkit-unassigned] [Bug 147091] Media Session: test 'Transient Solo' interruptions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147091

Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #257064|review?                     |review+
              Flags|                            |

--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 257064
  --> https://bugs.webkit.org/attachment.cgi?id=257064
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257064&action=review

> LayoutTests/media/session/transient-solo-interruptions.html:14
> +            if (window.testRunner) {
> +                testRunner.dumpAsText();
> +                testRunner.waitUntilDone();
> +            }

Nit: this isn't necessary because you include video-test.js.

> LayoutTests/media/session/transient-solo-interruptions.html:16
> +            window.jsTestIsAsync = true;

Nit: this is unnecessary, it isn't used by the video testing harness.

> LayoutTests/media/session/transient-solo-interruptions.html:30
> +            document.getElementById("video").play();

Nit: there is only one <video> so you can just use "video" instead of searching for the element.

> LayoutTests/media/session/transient-solo-interruptions.html:35
> +            document.getElementById("video").onplaying = null;

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150727/bdfafaae/attachment-0001.html>