<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: test 'Transient Solo' interruptions"
href="https://bugs.webkit.org/show_bug.cgi?id=147091">bug 147091</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #257064 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: test 'Transient Solo' interruptions"
href="https://bugs.webkit.org/show_bug.cgi?id=147091#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: test 'Transient Solo' interruptions"
href="https://bugs.webkit.org/show_bug.cgi?id=147091">bug 147091</a>
from <span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=257064&action=diff" name="attach_257064" title="Patch">attachment 257064</a> <a href="attachment.cgi?id=257064&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=257064&action=review">https://bugs.webkit.org/attachment.cgi?id=257064&action=review</a>
<span class="quote">> LayoutTests/media/session/transient-solo-interruptions.html:14
> + if (window.testRunner) {
> + testRunner.dumpAsText();
> + testRunner.waitUntilDone();
> + }</span >
Nit: this isn't necessary because you include video-test.js.
<span class="quote">> LayoutTests/media/session/transient-solo-interruptions.html:16
> + window.jsTestIsAsync = true;</span >
Nit: this is unnecessary, it isn't used by the video testing harness.
<span class="quote">> LayoutTests/media/session/transient-solo-interruptions.html:30
> + document.getElementById("video").play();</span >
Nit: there is only one <video> so you can just use "video" instead of searching for the element.
<span class="quote">> LayoutTests/media/session/transient-solo-interruptions.html:35
> + document.getElementById("video").onplaying = null;</span >
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>