[Webkit-unassigned] [Bug 139153] Web Inspector: support live editing of rule selectors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 24 11:17:08 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=139153

--- Comment #5 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 257431
  --> https://bugs.webkit.org/attachment.cgi?id=257431
[Proposed] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257431&action=review

>> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js:131
>> +    };
> 
> We should find a central place for this to be shared with other places we have the config. CSSStyleManager should really encapsulate DOMAgent.highlightSelector and DOMAgent.highlightNode, along with the colors used.

Actually DOMTreeManager is likely the right manager. It has some of this encapsulation already, it should have more. Agent calls should stay in the managers as much as possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150724/9685e486/attachment-0001.html>


More information about the webkit-unassigned mailing list