<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: support live editing of rule selectors"
href="https://bugs.webkit.org/show_bug.cgi?id=139153#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: support live editing of rule selectors"
href="https://bugs.webkit.org/show_bug.cgi?id=139153">bug 139153</a>
from <span class="vcard"><a class="email" href="mailto:timothy@apple.com" title="Timothy Hatcher <timothy@apple.com>"> <span class="fn">Timothy Hatcher</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=257431&action=diff" name="attach_257431" title="[Proposed] Patch">attachment 257431</a> <a href="attachment.cgi?id=257431&action=edit" title="[Proposed] Patch">[details]</a></span>
[Proposed] Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=257431&action=review">https://bugs.webkit.org/attachment.cgi?id=257431&action=review</a>
<span class="quote">>> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js:131
>> + };
>
> We should find a central place for this to be shared with other places we have the config. CSSStyleManager should really encapsulate DOMAgent.highlightSelector and DOMAgent.highlightNode, along with the colors used.</span >
Actually DOMTreeManager is likely the right manager. It has some of this encapsulation already, it should have more. Agent calls should stay in the managers as much as possible.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>