[Webkit-unassigned] [Bug 125920] [MIPS] Use shorter j <address> jump in MacroAssembler::replaceWithJump.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 24 05:14:46 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=125920

ssseintr <ssseintr1 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ssseintr1 at gmail.com

--- Comment #2 from ssseintr <ssseintr1 at gmail.com> ---
+        } else if (isWithin256MB(reinterpret_cast<int8_t*>(result) + bytes, bytes)) {
+            // 2nd half is good, release 1st half.
+            if (munmap(result, bytes))
+                CRASH();
+        } else


I think the code is wrong here.
As we are only returning 2nd half of our result, result should be changed as result + bytes. (i.e, result = reinterpret_cast<int8_t*>(result) + bytes, bytes);)

Please comment me, if I'm wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150724/4f64c81b/attachment.html>


More information about the webkit-unassigned mailing list