<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ssseintr1@gmail.com" title="ssseintr <ssseintr1@gmail.com>"> <span class="fn">ssseintr</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [MIPS] Use shorter j <address> jump in MacroAssembler::replaceWithJump."
href="https://bugs.webkit.org/show_bug.cgi?id=125920">bug 125920</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>ssseintr1@gmail.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [MIPS] Use shorter j <address> jump in MacroAssembler::replaceWithJump."
href="https://bugs.webkit.org/show_bug.cgi?id=125920#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [MIPS] Use shorter j <address> jump in MacroAssembler::replaceWithJump."
href="https://bugs.webkit.org/show_bug.cgi?id=125920">bug 125920</a>
from <span class="vcard"><a class="email" href="mailto:ssseintr1@gmail.com" title="ssseintr <ssseintr1@gmail.com>"> <span class="fn">ssseintr</span></a>
</span></b>
<pre>+ } else if (isWithin256MB(reinterpret_cast<int8_t*>(result) + bytes, bytes)) {
+ // 2nd half is good, release 1st half.
+ if (munmap(result, bytes))
+ CRASH();
+ } else
I think the code is wrong here.
As we are only returning 2nd half of our result, result should be changed as result + bytes. (i.e, result = reinterpret_cast<int8_t*>(result) + bytes, bytes);)
Please comment me, if I'm wrong.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>