[Webkit-unassigned] [Bug 147222] Implement WebAssembly modules

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 23 12:59:12 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=147222

Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #257366|review?                     |review-
              Flags|                            |

--- Comment #6 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 257366
  --> https://bugs.webkit.org/attachment.cgi?id=257366
Remove m_arrayBuffer for now as per discussion.

View in context: https://bugs.webkit.org/attachment.cgi?id=257366&action=review

You should probably also make the corresponding project file changes to Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj and Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters.

> Source/JavaScriptCore/wasm/JSWASMModule.cpp:40
> +    JSWASMModule* thisObject = static_cast<JSWASMModule*>(cell);

Sorry I didn't catch this the first time.  You should use a jsCast here instead:
    JSWASMModule* thisObject = jsCast<JSWASMModule*>(cell);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150723/905eb0a2/attachment.html>


More information about the webkit-unassigned mailing list