<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mark.lam@apple.com" title="Mark Lam <mark.lam@apple.com>"> <span class="fn">Mark Lam</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement WebAssembly modules"
href="https://bugs.webkit.org/show_bug.cgi?id=147222">bug 147222</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #257366 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement WebAssembly modules"
href="https://bugs.webkit.org/show_bug.cgi?id=147222#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement WebAssembly modules"
href="https://bugs.webkit.org/show_bug.cgi?id=147222">bug 147222</a>
from <span class="vcard"><a class="email" href="mailto:mark.lam@apple.com" title="Mark Lam <mark.lam@apple.com>"> <span class="fn">Mark Lam</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=257366&action=diff" name="attach_257366" title="Remove m_arrayBuffer for now as per discussion.">attachment 257366</a> <a href="attachment.cgi?id=257366&action=edit" title="Remove m_arrayBuffer for now as per discussion.">[details]</a></span>
Remove m_arrayBuffer for now as per discussion.
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=257366&action=review">https://bugs.webkit.org/attachment.cgi?id=257366&action=review</a>
You should probably also make the corresponding project file changes to Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj and Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters.
<span class="quote">> Source/JavaScriptCore/wasm/JSWASMModule.cpp:40
> + JSWASMModule* thisObject = static_cast<JSWASMModule*>(cell);</span >
Sorry I didn't catch this the first time. You should use a jsCast here instead:
JSWASMModule* thisObject = jsCast<JSWASMModule*>(cell);</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>