[Webkit-unassigned] [Bug 147222] Implement WebAssembly modules

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147222

Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #257359|review?                     |review-
              Flags|                            |

--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 257359
  --> https://bugs.webkit.org/attachment.cgi?id=257359
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257359&action=review

The patch looks good to me in general, but I think we should remove the m_arrayBuffer field until we know how it will be used.

> Source/JavaScriptCore/ChangeLog:7
> +

Please add a short comment here like:
"Introducing the boiler plate data structure for the WebAssembly module.  WASM functionality will be added in a subsequent patch."

>> Source/JavaScriptCore/wasm/JSWASMModule.h:69
>> +    WriteBarrier<JSArrayBuffer> m_arrayBuffer;
> 
> What is this m_arrayBuffer for?  Is it the buffer to hold the WASM source that we load?  If so, does it really need to be a JS property is accessible from JS code?

I spoke with Sukol offline.  This buffer is potentially needed for some analog of the passed in buffer in the "Putting It All Together" section of the asm.js spec: http://asmjs.org/spec/latest/.  However, it isn't clear from the spec how this would really work yet.  I think it's better to not include this m_arrayBuffer for now until we more concrete details.  In contrast, the m_functions is fine because it is clear that we'll storing the instantiated WASM functions there.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150723/5f82b604/attachment.html>