<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mark.lam@apple.com" title="Mark Lam <mark.lam@apple.com>"> <span class="fn">Mark Lam</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement WebAssembly modules"
href="https://bugs.webkit.org/show_bug.cgi?id=147222">bug 147222</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #257359 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement WebAssembly modules"
href="https://bugs.webkit.org/show_bug.cgi?id=147222#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement WebAssembly modules"
href="https://bugs.webkit.org/show_bug.cgi?id=147222">bug 147222</a>
from <span class="vcard"><a class="email" href="mailto:mark.lam@apple.com" title="Mark Lam <mark.lam@apple.com>"> <span class="fn">Mark Lam</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=257359&action=diff" name="attach_257359" title="Patch">attachment 257359</a> <a href="attachment.cgi?id=257359&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=257359&action=review">https://bugs.webkit.org/attachment.cgi?id=257359&action=review</a>
The patch looks good to me in general, but I think we should remove the m_arrayBuffer field until we know how it will be used.
<span class="quote">> Source/JavaScriptCore/ChangeLog:7
> +</span >
Please add a short comment here like:
"Introducing the boiler plate data structure for the WebAssembly module. WASM functionality will be added in a subsequent patch."
<span class="quote">>> Source/JavaScriptCore/wasm/JSWASMModule.h:69
>> + WriteBarrier<JSArrayBuffer> m_arrayBuffer;
>
> What is this m_arrayBuffer for? Is it the buffer to hold the WASM source that we load? If so, does it really need to be a JS property is accessible from JS code?</span >
I spoke with Sukol offline. This buffer is potentially needed for some analog of the passed in buffer in the "Putting It All Together" section of the asm.js spec: <a href="http://asmjs.org/spec/latest/">http://asmjs.org/spec/latest/</a>. However, it isn't clear from the spec how this would really work yet. I think it's better to not include this m_arrayBuffer for now until we more concrete details. In contrast, the m_functions is fine because it is clear that we'll storing the instantiated WASM functions there.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>