[Webkit-unassigned] [Bug 147211] AX: AccessibilityNodeObject::childrenChanged() generates too many AXLiveRegionChanged notifications

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147211

--- Comment #6 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 257361
  --> https://bugs.webkit.org/attachment.cgi?id=257361
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257361&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:1164
> +    for (auto& object  : m_liveRegionObjectsSet)

spacing is wrong

> Source/WebCore/accessibility/AXObjectCache.h:297
> +    void liveRegionChangedNotificationPostTimerFired();

this should probably go with the other functions, so that the ivars stay together

> LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent.html:40
> +            // Since there is a time delay for a AXLiveRegionChanged notification to be sent,

see comment below about comment

> LayoutTests/platform/mac/accessibility/aria-liveregions-notifications.html:43
> +        // Since there is a time delay for a AXLiveRegionChanged notification to be sent,

this comment should be "AXLiveRegionsChanged notifications are sent after a delay, so in order to ensure we get an notification for each operation we should avoid coalescing which can occur"

> LayoutTests/platform/mac/accessibility/aria-multiple-liveregions-notification.html:75
> +        if (liveRegionChangeCount == 2) {

you should add a shouldBeTrue(liveRegionChangeCount, 2)
here

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150723/1baca51a/attachment.html>