<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: AccessibilityNodeObject::childrenChanged() generates too many AXLiveRegionChanged notifications"
href="https://bugs.webkit.org/show_bug.cgi?id=147211#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: AccessibilityNodeObject::childrenChanged() generates too many AXLiveRegionChanged notifications"
href="https://bugs.webkit.org/show_bug.cgi?id=147211">bug 147211</a>
from <span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=257361&action=diff" name="attach_257361" title="patch">attachment 257361</a> <a href="attachment.cgi?id=257361&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=257361&action=review">https://bugs.webkit.org/attachment.cgi?id=257361&action=review</a>
<span class="quote">> Source/WebCore/accessibility/AXObjectCache.cpp:1164
> + for (auto& object : m_liveRegionObjectsSet)</span >
spacing is wrong
<span class="quote">> Source/WebCore/accessibility/AXObjectCache.h:297
> + void liveRegionChangedNotificationPostTimerFired();</span >
this should probably go with the other functions, so that the ivars stay together
<span class="quote">> LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent.html:40
> + // Since there is a time delay for a AXLiveRegionChanged notification to be sent,</span >
see comment below about comment
<span class="quote">> LayoutTests/platform/mac/accessibility/aria-liveregions-notifications.html:43
> + // Since there is a time delay for a AXLiveRegionChanged notification to be sent,</span >
this comment should be "AXLiveRegionsChanged notifications are sent after a delay, so in order to ensure we get an notification for each operation we should avoid coalescing which can occur"
<span class="quote">> LayoutTests/platform/mac/accessibility/aria-multiple-liveregions-notification.html:75
> + if (liveRegionChangeCount == 2) {</span >
you should add a shouldBeTrue(liveRegionChangeCount, 2)
here</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>