[Webkit-unassigned] [Bug 147173] Animated images should animate in previews

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147173

--- Comment #3 from Beth Dakin <bdakin at apple.com> ---
(In reply to comment #2)
> Comment on attachment 257219 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257219&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:69
> > +- (UIViewController *)_webView:(WKWebView *)webView previewViewControllerForAnimatedImageAtURL:(NSURL *)url defaultActions:(NSArray *)actions elementInfo:(_WKActivatedElementInfo *)elementInfo imageSize:(CGSize)imageSize WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA);
> 
> This (and some of the earlier-added) NSArray * argument should be a
> WK_ARRAY() of the appropriate type.
> 

Fixed this and the earlier-added arguments!

> > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3288
> > +            RetainPtr<NSArray> actions = [_actionSheetAssistant defaultActionsForImageSheet:elementInfo.get()];
> 
> Why get the actions and change _previewType outside the below if?

No good reason! Fixed.

Thanks Dan!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150722/942a249d/attachment.html>