<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Animated images should animate in previews"
href="https://bugs.webkit.org/show_bug.cgi?id=147173#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Animated images should animate in previews"
href="https://bugs.webkit.org/show_bug.cgi?id=147173">bug 147173</a>
from <span class="vcard"><a class="email" href="mailto:bdakin@apple.com" title="Beth Dakin <bdakin@apple.com>"> <span class="fn">Beth Dakin</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=147173#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=257219&action=diff" name="attach_257219" title="Patch">attachment 257219</a> <a href="attachment.cgi?id=257219&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=257219&action=review">https://bugs.webkit.org/attachment.cgi?id=257219&action=review</a>
>
> > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:69
> > +- (UIViewController *)_webView:(WKWebView *)webView previewViewControllerForAnimatedImageAtURL:(NSURL *)url defaultActions:(NSArray *)actions elementInfo:(_WKActivatedElementInfo *)elementInfo imageSize:(CGSize)imageSize WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA);
>
> This (and some of the earlier-added) NSArray * argument should be a
> WK_ARRAY() of the appropriate type.
> </span >
Fixed this and the earlier-added arguments!
<span class="quote">> > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3288
> > + RetainPtr<NSArray> actions = [_actionSheetAssistant defaultActionsForImageSheet:elementInfo.get()];
>
> Why get the actions and change _previewType outside the below if?</span >
No good reason! Fixed.
Thanks Dan!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>