[Webkit-unassigned] [Bug 147173] Animated images should animate in previews

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147173

mitz at webkit.org <mitz at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #257219|review?                     |review+
              Flags|                            |

--- Comment #2 from mitz at webkit.org <mitz at webkit.org> ---
Comment on attachment 257219
  --> https://bugs.webkit.org/attachment.cgi?id=257219
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257219&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:69
> +- (UIViewController *)_webView:(WKWebView *)webView previewViewControllerForAnimatedImageAtURL:(NSURL *)url defaultActions:(NSArray *)actions elementInfo:(_WKActivatedElementInfo *)elementInfo imageSize:(CGSize)imageSize WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA);

This (and some of the earlier-added) NSArray * argument should be a WK_ARRAY() of the appropriate type.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3288
> +            RetainPtr<NSArray> actions = [_actionSheetAssistant defaultActionsForImageSheet:elementInfo.get()];

Why get the actions and change _previewType outside the below if?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150722/6d44dcef/attachment.html>