<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mitz@webkit.org" title="mitz@webkit.org <mitz@webkit.org>"> <span class="fn">mitz@webkit.org</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Animated images should animate in previews"
href="https://bugs.webkit.org/show_bug.cgi?id=147173">bug 147173</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #257219 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Animated images should animate in previews"
href="https://bugs.webkit.org/show_bug.cgi?id=147173#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Animated images should animate in previews"
href="https://bugs.webkit.org/show_bug.cgi?id=147173">bug 147173</a>
from <span class="vcard"><a class="email" href="mailto:mitz@webkit.org" title="mitz@webkit.org <mitz@webkit.org>"> <span class="fn">mitz@webkit.org</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=257219&action=diff" name="attach_257219" title="Patch">attachment 257219</a> <a href="attachment.cgi?id=257219&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=257219&action=review">https://bugs.webkit.org/attachment.cgi?id=257219&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:69
> +- (UIViewController *)_webView:(WKWebView *)webView previewViewControllerForAnimatedImageAtURL:(NSURL *)url defaultActions:(NSArray *)actions elementInfo:(_WKActivatedElementInfo *)elementInfo imageSize:(CGSize)imageSize WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA);</span >
This (and some of the earlier-added) NSArray * argument should be a WK_ARRAY() of the appropriate type.
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3288
> + RetainPtr<NSArray> actions = [_actionSheetAssistant defaultActionsForImageSheet:elementInfo.get()];</span >
Why get the actions and change _previewType outside the below if?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>