[Webkit-unassigned] [Bug 147043] Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147043

--- Comment #6 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 257148
  --> https://bugs.webkit.org/attachment.cgi?id=257148
Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.

View in context: https://bugs.webkit.org/attachment.cgi?id=257148&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:110
> +        queueInfo.branch = queueInfo.combinedQueues ?  null : queueInfo.branch || this.defaultBranches;

Why can't a combined queue be on a branch? We don't have any now, but I don't see any intrinsic reason for this limitation.

The operator precedence here seems non-obvious enough that I'd have appreciated parentheses.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:28
> +    var all_branch = {};

"all_branch" is neither named according to WebKit style, nor grammatically correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150721/053c1431/attachment-0001.html>