<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo."
href="https://bugs.webkit.org/show_bug.cgi?id=147043#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo."
href="https://bugs.webkit.org/show_bug.cgi?id=147043">bug 147043</a>
from <span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=257148&action=diff" name="attach_257148" title="Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.">attachment 257148</a> <a href="attachment.cgi?id=257148&action=edit" title="Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.">[details]</a></span>
Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=257148&action=review">https://bugs.webkit.org/attachment.cgi?id=257148&action=review</a>
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:110
> + queueInfo.branch = queueInfo.combinedQueues ? null : queueInfo.branch || this.defaultBranches;</span >
Why can't a combined queue be on a branch? We don't have any now, but I don't see any intrinsic reason for this limitation.
The operator precedence here seems non-obvious enough that I'd have appreciated parentheses.
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:28
> + var all_branch = {};</span >
"all_branch" is neither named according to WebKit style, nor grammatically correct.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>